Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referenced objects and extendable object pool #41

Merged

Conversation

GwnDaan
Copy link
Member

@GwnDaan GwnDaan commented Dec 14, 2023

  • Added member function to get all the objects by id, that have been referenced by the object in question
  • Added ability to extend an ObjectPool by another binary encoded object pool

@GwnDaan GwnDaan added the iso: virtual terminal Related to the ISO-11783:6 standard label Dec 14, 2023
@GwnDaan GwnDaan self-assigned this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (bedbae3) 11.28% compared to head (799b88d) 10.87%.

Files Patch % Lines
src/object_pool/object.rs 0.00% 102 Missing ⚠️
src/object_pool/object_pool.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           daan/fix-nullable-object-ids-      #41      +/-   ##
=================================================================
- Coverage                          11.28%   10.87%   -0.42%     
=================================================================
  Files                                 17       17              
  Lines                               2675     2778     +103     
=================================================================
  Hits                                 302      302              
- Misses                              2373     2476     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JannesBrands JannesBrands merged commit b40a528 into daan/fix-nullable-object-ids- Jan 26, 2024
7 of 9 checks passed
@JannesBrands JannesBrands deleted the daan/object-reference-list branch January 26, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iso: virtual terminal Related to the ISO-11783:6 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants