Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colour map not initializing #42

Open
wants to merge 1 commit into
base: daan/fix-nullable-object-ids-
Choose a base branch
from

Conversation

GwnDaan
Copy link
Member

@GwnDaan GwnDaan commented Dec 15, 2023

Due to casting 256 to u8 we ended up with 1. So this loop basically only ran once for index i=0, and the rest of the map didn't initialize correctly. This PR will fix that.

@GwnDaan GwnDaan added the iso: virtual terminal Related to the ISO-11783:6 standard label Dec 15, 2023
@GwnDaan GwnDaan self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (799b88d) 10.87% compared to head (ca329f0) 11.01%.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           daan/object-reference-list      #42      +/-   ##
==============================================================
+ Coverage                       10.87%   11.01%   +0.14%     
==============================================================
  Files                              17       17              
  Lines                            2778     2778              
==============================================================
+ Hits                              302      306       +4     
+ Misses                           2476     2472       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from daan/object-reference-list to daan/fix-nullable-object-ids- January 26, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iso: virtual terminal Related to the ISO-11783:6 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant