Fix linting checks on NAME #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 |
Notgnoshi
previously approved these changes
Aug 8, 2023
Notgnoshi
force-pushed
the
ca-adg/name-lint
branch
from
aaad2fe
to
afa4b92
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 74ce6d9 |
Alters lint rules to allow bool literals in asserts and allows returns. Fixes other linting issues.
ad3154
force-pushed
the
ca-adg/name-lint
branch
from
afa4b92
to
74ce6d9
Compare
|
This PR is ready for re-review |
Notgnoshi
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some failed checks from clippy that didn't make it into #6