Skip to content

Commit

Permalink
Restore explanation for NOMERGES flag
Browse files Browse the repository at this point in the history
The comment was remved in 1e5355e

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
  • Loading branch information
mmichal10 committed Sep 20, 2024
1 parent ae2d14d commit 3b49547
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions configure.d/1_queue_limits.conf
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ apply() {
exp_q->limits.max_write_same_sectors = 0;
}"

# Workaround for RHEL/CentOS 7.3 bug in kernel.
# Merging implementation on blk-mq does not respec virt boundary
# restriction and front merges bios with non-zero offsets.
# This leads to request with gaps between bios and in consequence
# triggers BUG_ON() in nvme driver or silently corrupts data.
# To prevent this, disable merging on cache queue if there are
# requirements regarding virt boundary (marking bios with REQ_NOMERGE
# does not solve this problem).
add_function "
static inline void cas_cache_set_no_merges_flag(struct request_queue *cache_q)
{
Expand Down

0 comments on commit 3b49547

Please sign in to comment.