Implement cache detach/attach #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalste
force-pushed
the
cache_detach
branch
4 times, most recently
from
48ca47f to
4a18a15
Compare
robertbaldyga
requested changes
Sep 9, 2024
robertbaldyga
previously approved these changes
Sep 9, 2024
rafalste
force-pushed
the
cache_detach
branch
from
4a18a15 to
ea5c2cf
Compare
robertbaldyga
previously approved these changes
Sep 9, 2024
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
New cache device must have all the same properties then the previously attached one. Keeping cache properties in cache priv also allows to add new cores to detached cache instance. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Instead of trying to access properties of potenially unavaliable cache device use properties saved in cache priv Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
An attempt to print a string of zero length was crashing casadm. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
previously approved these changes
Sep 9, 2024
rafalste
dismissed stale reviews from mmichal10 and robertbaldyga
via
682d9a1
rafalste
force-pushed
the
cache_detach
branch
from
ea5c2cf to
682d9a1
Compare
mmichal10
previously approved these changes
Sep 9, 2024
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Cache start and cache attach will share the same code in casadm; the following refactor is supposed to facilitate reusing the existing code in next commits Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Jan Musial <jan.musial@huawei.com>
rafalste
force-pushed
the
cache_detach
branch
from
682d9a1 to
16690e1
Compare
mmichal10
approved these changes
Sep 9, 2024
robertbaldyga
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.