configure framework: detect make_req_fn type #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmichal10
force-pushed
the
fix-make-req-type
branch
4 times, most recently
from
d4fd518 to
6fc34bc
Compare
robertbaldyga
requested changes
Sep 25, 2024
configure.d/1_make_req_type.conf
Outdated
| if compile_module $cur_name "struct block_device_operations x; x.submit_bio;" "linux/blkdev.h"; | ||
| then | ||
| # If it's impossible to assign the casted return value of submit_bio() | ||
| # to a variable we're assuming the function is of type void. |
robertbaldyga
requested changes
Sep 25, 2024
configure.d/1_make_req_type.conf
Outdated
| # and removes make_request_fn | ||
| if compile_module $cur_name "struct block_device_operations x; x.submit_bio;" "linux/blkdev.h"; | ||
| then | ||
| # If it's impossible to assign the casted return value of submit_bio() |
There was a problem hiding this comment.
s/assign the casted return value/cast the return value/
There was a problem hiding this comment.
This is not the assignment that fails. It's the casting operation itself.
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
fix-make-req-type
branch
from
6fc34bc to
8fbbf31
Compare
robertbaldyga
approved these changes
Sep 25, 2024
rafalste
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.