adding tests for by-id core path #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karolina Rogowska <karolina.rogowska@intel.com>
arutk
requested changes
Mar 2, 2022
| @@ -0,0 +1,216 @@ | |||
| # | |||
| # Copyright(c) 2021 Intel Corporation | |||
Comment on lines
+56
to
+58
| Symlink(os.path.join(by_id_dir, item.full_path)) # parse_ls_output returns | ||
| for item in parse_ls_output(ls(by_id_dir), by_id_dir) # symlinks without path | ||
| if isinstance(item, Symlink) |
There was a problem hiding this comment.
Resolving by-id link seems to be a very common operation. I suggest to add a helper function for this in the framework.
Comment on lines
+65
to
+71
| with TestRun.step("Start cache and add cores"): | ||
| paths_from_dmesg = [] | ||
| cache = casadm.start_cache(cache_part, force=True) | ||
| for i in range(cores_number): | ||
| core_dev.partitions[i].path = selected_links[i].full_path | ||
| cache.add_core(core_dev.partitions[i]) | ||
| paths_from_dmesg.append(get_added_core_path_from_dmesg()) |
There was a problem hiding this comment.
there is no need to parse dmesg. "casadm -L -b" will print paths exactly as returned by OCF, without any translation.
Deixx
reviewed
Sep 3, 2024
Comment on lines
11
to
26
| from api.cas import casadm, casctl, casadm_parser | ||
| from api.cas.casadm_parser import get_caches, get_cores | ||
| from api.cas.cache_config import CacheMode | ||
| from api.cas.casadm import list_caches | ||
| from api.cas.casadm_parser import get_caches, get_cores, get_cas_devices_dict | ||
| from api.cas.cli_messages import check_stdout_msg, no_caches_running | ||
| from api.cas.init_config import InitConfig | ||
| from core.test_run import TestRun | ||
| from storage_devices.disk import DiskType, DiskTypeSet, DiskTypeLowerThan | ||
| from test_utils.filesystem.file import File | ||
| from test_tools.dd import Dd | ||
| from test_tools.disk_utils import Filesystem | ||
| from test_tools.fs_utils import parse_ls_output, readlink, ls | ||
| from test_utils import fstab | ||
| from test_tools.dd import Dd | ||
| from test_utils.filesystem.file import File | ||
| from test_utils.filesystem.symlink import Symlink | ||
| from test_utils.os_utils import drop_caches, sync | ||
| from test_utils.size import Unit, Size |
There was a problem hiding this comment.
could use some cleanup, like removing casadm_parser as a whole module from imports (all the needed functions from casadm_parser are imported) or importing casadm and from casadm
Deixx
reviewed
Sep 3, 2024
|
Moved to #1518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original review: #539
This PR needs functionality from: https://github.com/Open-CAS/test-framework/pull/259
Signed-off-by: Karolina Rogowska karolina.rogowska@intel.com