-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support axis keyword in array_contains #152
Conversation
@ValentinaHutter another small PR to have a look over please! :) |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 78.75% 78.95% +0.19%
==========================================
Files 27 28 +1
Lines 1177 1207 +30
==========================================
+ Hits 927 953 +26
- Misses 250 254 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think, since array_contains
is labeled as a reducer
, it might be useful to add a small test to run reduce_dimension(reducer=array_contains)
.
def test_array_contains_axis(): | ||
data = np.array([[4, 5, 6], [5, 7, 9]]) | ||
result = array_contains(data, 5, axis=1) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test does not have an assert
, yet.
Ah, good points - fixed both, thanks! :) |
Closes #63