Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantiles to be compliant with 2.0.0 and accept list inputs #204

Closed
wants to merge 1 commit into from

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Dec 14, 2023

Fix quantiles to be compliant with 2.0.0 and accept list inputs.

Found by the new test suite and want to make you aware. I won't have time to add tests, this is more a bug report rather than a full PR.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (8d9e3fb) to head (44dd404).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...neo_processes_dask/process_implementations/math.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   79.42%   79.29%   -0.14%     
==========================================
  Files          30       30              
  Lines        1468     1473       +5     
==========================================
+ Hits         1166     1168       +2     
- Misses        302      305       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-mohr m-mohr requested review from ValentinaHutter and removed request for SerRichard December 14, 2023 13:51
@m-mohr m-mohr added the bug Something isn't working label Dec 14, 2023
@ValentinaHutter
Copy link
Collaborator

I just realized that I now did this in a separate PR rather than in your draft. I will close this one, as it is done now.

@m-mohr m-mohr deleted the quantiles branch September 16, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants