Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fit_curve and predict_curve #57

Conversation

ValentinaHutter
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #57 (8e82b61) into main (8bbb322) will increase coverage by 1.14%.
The diff coverage is 75.43%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   58.25%   59.39%   +1.14%     
==========================================
  Files          22       23       +1     
  Lines         800      857      +57     
==========================================
+ Hits          466      509      +43     
- Misses        334      348      +14     
Impacted Files Coverage Δ
...s_dask/process_implementations/ml/curve_fitting.py 75.43% <75.43%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@clausmichele
Copy link
Member

I do not see much difference with the previous implementation of fit_curve and predict_curve here https://github.com/Open-EO/openeo-processes-python/blob/7407d8d28433978aa47749707e2122ba0f709c11/src/openeo_processes/cubes.py#L623

Do you think this will be enough to produce a result on a large area? Are there improvements planned?

@ValentinaHutter
Copy link
Collaborator Author

The intention of this PR was just to get to feature parity with the old processes implementation, so this did not really change. Updates on the scalability will be adressed in a separate PR.

@LukeWeidenwalker
Copy link
Contributor

Closing in favor of #139

@LukeWeidenwalker LukeWeidenwalker deleted the EODCAPI-36-re-implement-fit-curve-process-in-openeo-processes-dask branch August 22, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants