-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub App to push version bumps #1443
Conversation
+ remove Appveyor files + remove docs/ (will be build on gh-pages) + update badges
Will not push to gh-pages during PR, only when merged + remove unused action
#Conflicts: # appveyor-nightly.yml # appveyor.yml
…ctions # Conflicts: # docs/dev/LICENSE-text.html # docs/dev/articles/create-individual.html # docs/dev/articles/create-run-population.html # docs/dev/articles/create-run-population_files/figure-html/getOutputValues-1.png # docs/dev/articles/create-run-population_files/figure-html/getOutputValuesForIndividual-1.png # docs/dev/articles/data-combined-plotting.html # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-10-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-12-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-13-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-3-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-4-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-5-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-6-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-7-1.png # docs/dev/articles/data-combined-plotting_files/figure-html/unnamed-chunk-8-1.png # docs/dev/articles/data-combined.html # docs/dev/articles/data-combined_files/figure-html/unnamed-chunk-10-1.png # docs/dev/articles/data-combined_files/figure-html/unnamed-chunk-11-1.png # docs/dev/articles/data-combined_files/figure-html/unnamed-chunk-12-1.png # docs/dev/articles/data-combined_files/figure-html/unnamed-chunk-6-1.png # docs/dev/articles/data-combined_files/figure-html/unnamed-chunk-7-1.png # docs/dev/articles/efficient-calculations.html # docs/dev/articles/index.html # docs/dev/articles/load-get.html # docs/dev/articles/observed-data.html # docs/dev/articles/ospsuite.html # docs/dev/articles/pk-analysis.html # docs/dev/articles/run-simulation.html # docs/dev/articles/sensitivity-analysis.html # docs/dev/articles/set-values.html # docs/dev/articles/table-parameters.html # docs/dev/articles/unit-conversion.html # docs/dev/authors.html # docs/dev/deps/bootstrap-5.3.1/bootstrap.min.css # docs/dev/index.html # docs/dev/news/index.html # docs/dev/pkgdown.js # docs/dev/pkgdown.yml # docs/dev/reference/AgingData.html # docs/dev/reference/AllMatchingMethod.html # docs/dev/reference/AllPathsInMethod.html # docs/dev/reference/ApiConfig.html # docs/dev/reference/Application.html # docs/dev/reference/Cache.html # docs/dev/reference/CompareBy.html # docs/dev/reference/Container.html # docs/dev/reference/DataAggregationMethods.html # docs/dev/reference/DataColumn.html # docs/dev/reference/DataCombined.html # docs/dev/reference/DataErrorType.html # docs/dev/reference/DataImporterConfiguration.html # docs/dev/reference/DataRepository.html # docs/dev/reference/DataSet.html # docs/dev/reference/DefaultPlotConfiguration.html # docs/dev/reference/DotNetWrapper.html # docs/dev/reference/Entity.html # docs/dev/reference/Formula.html # docs/dev/reference/Gender.html # docs/dev/reference/HumanPopulation.html # docs/dev/reference/IndividualCharacteristics.html # docs/dev/reference/Interval.html # docs/dev/reference/Molecule.html # docs/dev/reference/MoleculeOntogeny.html # docs/dev/reference/MoleculeParameter.html # docs/dev/reference/ObjectBase.html # docs/dev/reference/OutputSchema.html # docs/dev/reference/OutputSelections.html # docs/dev/reference/PKParameter.html # docs/dev/reference/PKParameterSensitivity.html # docs/dev/reference/Parameter.html # docs/dev/reference/ParameterRange.html # docs/dev/reference/Population.html # docs/dev/reference/PopulationCharacteristics.html # docs/dev/reference/Quantity.html # docs/dev/reference/QuantityPKParameter.html # docs/dev/reference/QuantitySelection.html # docs/dev/reference/Rplot002.png # docs/dev/reference/Rplot003.png # docs/dev/reference/SensitivityAnalysis.html # docs/dev/reference/SensitivityAnalysisResults.html # docs/dev/reference/SensitivityAnalysisRunOptions.html # docs/dev/reference/Simulation.html # docs/dev/reference/SimulationBatch.html # docs/dev/reference/SimulationBatchOptions.html # docs/dev/reference/SimulationBatchRunValues.html # docs/dev/reference/SimulationPKAnalyses.html # docs/dev/reference/SimulationResults.html # docs/dev/reference/SimulationRunOptions.html # docs/dev/reference/SimulationSettings.html # docs/dev/reference/SnapshotParameter.html # docs/dev/reference/SolverSettings.html # docs/dev/reference/Species.html # docs/dev/reference/StandardContainer.html # docs/dev/reference/StandardOntogeny.html # docs/dev/reference/StandardPKParameter.html # docs/dev/reference/StandardPath.html # docs/dev/reference/UserDefinedPKParameter.html # docs/dev/reference/ValuePoint.html # docs/dev/reference/addOutputInterval.html # docs/dev/reference/addOutputs.html # docs/dev/reference/addUserDefinedPKParameter.html # docs/dev/reference/allAvailableDimensions.html # docs/dev/reference/allPKParameterNames.html # docs/dev/reference/calculatePKAnalyses.html # docs/dev/reference/calculateResiduals.html # docs/dev/reference/clearMemory.html # docs/dev/reference/clearOutputIntervals.html # docs/dev/reference/clearOutputs.html # docs/dev/reference/convertUnits.html # docs/dev/reference/createDistributions.html # docs/dev/reference/createImporterConfigurationForFile.html # docs/dev/reference/createIndividual.html # docs/dev/reference/createIndividualCharacteristics.html # docs/dev/reference/createPopulation.html # docs/dev/reference/createPopulationCharacteristics.html # docs/dev/reference/createSimulationBatch.html # docs/dev/reference/dataSetToDataFrame.html # docs/dev/reference/dot-ImporterErrorTypeToDataSetErrorType.html # docs/dev/reference/dot-addMissingGroupings.html # docs/dev/reference/dot-cleanVectorArgs.html # docs/dev/reference/dot-convertGeneralToSpecificPlotConfiguration.html # docs/dev/reference/dot-createAxesLabels.html # docs/dev/reference/dot-encodeUnit.html # docs/dev/reference/dot-expandPath.html # docs/dev/reference/dot-extractAggregatedSimulatedData.html # docs/dev/reference/dot-extractMostFrequentUnit.html # docs/dev/reference/dot-extractResidualsToTibble.html # docs/dev/reference/dot-geoRange.html # docs/dev/reference/dot-getAllEntitiesMatching.html # docs/dev/reference/dot-getAllEntityPathsIn.html # docs/dev/reference/dot-getConcurrentSimulationRunnerResults.html # docs/dev/reference/dot-getDimensionsEnum.html # docs/dev/reference/dot-getEntity.html # docs/dev/reference/dot-getNetTask.html # docs/dev/reference/dot-getNetTaskFromCache.html # docs/dev/reference/dot-getOspDimensions.html # docs/dev/reference/dot-getOspUnits.html # docs/dev/reference/dot-getPathToPKSimInstallDir.html # docs/dev/reference/dot-getPathToPKSimInstallDirFromFileSystem.html # docs/dev/reference/dot-getPathToPKSimInstallDirFromRegistry.html # docs/dev/reference/dot-getPropertyValue.html # docs/dev/reference/dot-getPropertyValues.html # docs/dev/reference/dot-getQuantityDisplayPaths.html # docs/dev/reference/dot-getUnitsEnum.html # docs/dev/reference/dot-initPackage.html # docs/dev/reference/dot-loadDataRepositoryFromPKML.html # docs/dev/reference/dot-makeDataFrameColumn.html # docs/dev/reference/dot-netEnumName.html # docs/dev/reference/dot-normRange.html # docs/dev/reference/dot-parameterValueListFrom.html # docs/dev/reference/dot-parseDimensionsXML.html # docs/dev/reference/dot-removeEmptyDataFrame.html # docs/dev/reference/dot-removeUnpairableDatasets.html # docs/dev/reference/dot-savePKAnalysesToCSV.html # docs/dev/reference/dot-savePopulationToCSV.html # docs/dev/reference/dot-saveResultsToCSV.html # docs/dev/reference/dot-saveSensitivityAnalysisResultsToCSV.html # docs/dev/reference/dot-scaleQuantityValues.html # docs/dev/reference/dot-setQuantityValues.html # docs/dev/reference/dot-toObjectType.html # docs/dev/reference/dot-unitConverter.html # docs/dev/reference/dot-validateHasUnit.html # docs/dev/reference/dot-validateScalarDataCombined.html # docs/dev/reference/exportIndividualSimulations.html # docs/dev/reference/exportPKAnalysesToCSV.html # docs/dev/reference/exportPopulationToCSV.html # docs/dev/reference/exportResultsToCSV.html # docs/dev/reference/exportSensitivityAnalysisResultsToCSV.html # docs/dev/reference/getAllContainerPathsIn.html # docs/dev/reference/getAllContainersMatching.html # docs/dev/reference/getAllMoleculePathsIn.html # docs/dev/reference/getAllMoleculesMatching.html # docs/dev/reference/getAllObserverPathsIn.html # docs/dev/reference/getAllParameterPathsIn.html # docs/dev/reference/getAllParametersForSensitivityAnalysisMatching.html # docs/dev/reference/getAllParametersMatching.html # docs/dev/reference/getAllQuantitiesMatching.html # docs/dev/reference/getAllQuantityPathsIn.html # docs/dev/reference/getAllStateVariableParametersPaths.html # docs/dev/reference/getAllStateVariablesPaths.html # docs/dev/reference/getBaseUnit.html # docs/dev/reference/getContainer.html # docs/dev/reference/getDimensionByName.html # docs/dev/reference/getDimensionForUnit.html # docs/dev/reference/getMolecule.html # docs/dev/reference/getOSPSuiteSetting.html # docs/dev/reference/getOutputValues.html # docs/dev/reference/getParameter.html # docs/dev/reference/getParameterDisplayPaths.html # docs/dev/reference/getQuantity.html # docs/dev/reference/getQuantityValuesByPath.html # docs/dev/reference/getSimulationTree.html # docs/dev/reference/getStandardMoleculeParameters.html # docs/dev/reference/getUnitsForDimension.html # docs/dev/reference/hasDimension.html # docs/dev/reference/hasUnit.html # docs/dev/reference/importPKAnalysesFromCSV.html # docs/dev/reference/importResultsFromCSV.html # docs/dev/reference/importSensitivityAnalysisResultsFromCSV.html # docs/dev/reference/index.html # docs/dev/reference/initPKSim.html # docs/dev/reference/isExplicitFormulaByPath.html # docs/dev/reference/loadAgingDataFromCSV.html # docs/dev/reference/loadDataImporterConfiguration.html # docs/dev/reference/loadDataSetFromPKML.html # docs/dev/reference/loadDataSetsFromExcel.html # docs/dev/reference/loadPopulation.html # docs/dev/reference/loadSimulation.html # docs/dev/reference/messages.html # docs/dev/reference/ospDimensions.html # docs/dev/reference/ospUnits.html # docs/dev/reference/ospsuiteSettingNames.html # docs/dev/reference/ospsuite_deprecated.html # docs/dev/reference/pkAnalysesToDataFrame.html # docs/dev/reference/pkParameterByName.html # docs/dev/reference/plotIndividualTimeProfile-1.png # docs/dev/reference/plotIndividualTimeProfile.html # docs/dev/reference/plotObservedVsSimulated-1.png # docs/dev/reference/plotObservedVsSimulated.html # docs/dev/reference/plotPopulationTimeProfile-1.png # docs/dev/reference/plotPopulationTimeProfile-2.png # docs/dev/reference/plotPopulationTimeProfile-3.png # docs/dev/reference/plotPopulationTimeProfile.html # docs/dev/reference/plotResidualsVsSimulated-1.png # docs/dev/reference/plotResidualsVsSimulated.html # docs/dev/reference/plotResidualsVsTime-1.png # docs/dev/reference/plotResidualsVsTime.html # docs/dev/reference/populationToDataFrame.html # docs/dev/reference/potentialVariableParameterPathsFor.html # docs/dev/reference/reexports.html # docs/dev/reference/removeAllUserDefinedPKParameters.html # docs/dev/reference/removeSimulationFromCache.html # docs/dev/reference/resetSimulationCache.html # docs/dev/reference/runSensitivityAnalysis.html # docs/dev/reference/runSimulation.html # docs/dev/reference/runSimulationBatches.html # docs/dev/reference/runSimulations.html # docs/dev/reference/saveDataSetToPKML.html # docs/dev/reference/saveSimulation.html # docs/dev/reference/scaleParameterValues.html # docs/dev/reference/setMoleculeInitialValues.html # docs/dev/reference/setMoleculeScaleDivisors.html # docs/dev/reference/setMoleculeValuesByPath.html # docs/dev/reference/setOutputInterval.html # docs/dev/reference/setOutputs.html # docs/dev/reference/setParameterValues.html # docs/dev/reference/setParameterValuesByPath.html # docs/dev/reference/setQuantityValuesByPath.html # docs/dev/reference/simulationResultsToDataFrame.html # docs/dev/reference/splitPopulationFile.html # docs/dev/reference/toBaseUnit.html # docs/dev/reference/toDisplayUnit.html # docs/dev/reference/toPathArray.html # docs/dev/reference/toPathString.html # docs/dev/reference/toUnit.html # docs/dev/reference/uniqueEntities.html # docs/dev/reference/updatePKParameter.html # docs/dev/reference/validateDimension.html # docs/dev/reference/validateUnit.html # docs/dev/search.json # docs/dev/sitemap.xml
#Conflicts: # appveyor-nightly.yml # appveyor.yml
+ refactor all jobs in one main workflow
+ rename to "bump..."
#Conflicts: # .github/workflows/bump-dev-version.yaml # .github/workflows/main-workflow.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that we don't have the develop branch anymore - it can be deleted from the trigger conditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 3ab28a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: how do we prevent that the commit executed by bump-dev-version triggers another on push workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding [skip actions]
in the commit message added by the action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Didn't know it works like this.
@@ -11,6 +11,8 @@ jobs: | |||
bump-dev-version: # only do that when actually merging in main/develop branch | |||
if: github.event_name != 'pull_request' | |||
uses: ./.github/workflows/bump-dev-version.yaml | |||
secrets: inherit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This inherits the secrets from the organization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment variables from the organization are inherited automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ remove trigger on "develop" branch
TO DO:
ACTIONS_MANAGER_APPID
andACTIONS_MANAGER_TOKEN
)