-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: remove MB and GB definition in utilities.h #242
Conversation
@bentheredonethat: |
@arnopo confirmed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -27,6 +27,9 @@ | |||
#include "xreg_cortexa53.h" | |||
#endif /* defined(versal) */ | |||
|
|||
#define MB (1024 * 1024UL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arnopo for this change.
Just to avoid any future warnings, we can do "#ifndef MB".
But, me or @bentheredonethat will do that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
The introduction of MB and GB macros introduces warnings in Zephyr build. Indeed they are already defined in zephyr/include/zephyr/sys/util.h. Remove them and put them back in lib/system/generic/xlnx_common/zynqmp_aarch64/sys.c. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Hi @bentheredonethat |
@arnopo I will provide fix. |
@arnopo @bentheredonethat done: #249 |
The introduction of MB and GB macros introduces warnings in Zephyr build.
Indeed they are already defined in zephyr/include/zephyr/sys/util.h. Remove them and put them back in
lib/system/generic/xlnx_common/zynqmp_aarch64/sys.c.