lib: Fix available error message in softirq #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message should state that there are no more available Soft IRQs. Signed-off-by: Andrew Davis <afd@ti.com>
arnopo
approved these changes
Apr 2, 2024
tnmysh
reviewed
May 17, 2024
| @@ -72,8 +72,7 @@ int metal_softirq_allocate(int num) | |||
| int irq_base; | |||
|
|
|||
| if ((metal_softirq_avail + num) >= metal_softirq_num) { | |||
| metal_log(METAL_LOG_ERROR, "No %d available soft irqs.\r\n", | |||
| num); | |||
| metal_log(METAL_LOG_ERROR, "No more available soft irqs\n"); | |||
There was a problem hiding this comment.
LGTM.
metal_error() can be used as well.
tnmysh
approved these changes
May 17, 2024
|
I missed this one for the release. Since it is a minor update for the trace I will add it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message should state that there are no more available Soft IRQs.