lib: system: nuttx: fix undeclared parameter compile error #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyr-7
force-pushed
the
fix_undeclared_err
branch
from
498f5c5
to
9efae62
Compare
tnmysh
approved these changes
Oct 16, 2024
edmooring
approved these changes
Oct 18, 2024
wyr-7
force-pushed
the
fix_undeclared_err
branch
from
9efae62
to
8b5739f
Compare
fix compile error: /nuttx/openamp/libmetal/lib/system/nuttx/device.c:16:22: error: 'io' undeclared (first use in this function) 16 | metal_unused(io); /nuttx/openamp/libmetal/lib/system/nuttx/device.c:14:53: error: unused parameter 'dev' [-Werror=unused-parameter] 14 | int metal_generic_dev_sys_open(struct metal_device *dev) ... Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com>
wyr-7
force-pushed
the
fix_undeclared_err
branch
from
8b5739f
to
53ff675
Compare
|
@arnopo Thanks, I have update. @edmooring @tnmysh |
arnopo
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Nit: We usually use the same approach as in the Linux Kernel for the hierarchy description in the commit subject. I will update the commit subject for this one. Please take it into account for other PRs.
lib/system/nuttx: fix undeclared parameter compile error
should become
lib: system; nuttx: fix undeclared parameter compile error
arnopo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix compile error:
/home/wyr/work/code/project/cardev/nuttx/openamp/libmetal/lib/system/nuttx/device.c:16:22: error: 'io' undeclared (first use in this function)
16 | metal_unused(io);
/home/wyr/work/code/project/cardev/nuttx/openamp/libmetal/lib/system/nuttx/device.c:14:53: error: unused parameter 'dev' [-Werror=unused-parameter]
14 | int metal_generic_dev_sys_open(struct metal_device *dev)
...