Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: system: fix missing metal_yield API for generic systems. #318

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

arnopo
Copy link
Contributor

@arnopo arnopo commented Oct 21, 2024

The metal_yield API needs also to be declared for the baremetal systems. This fix build issue in Open-amp for generic system:

/github/workspace/open-amp/lib/rpmsg/rpmsg_virtio.c:275:17: error: implicit declaration of function 'metal_yield'
275 | metal_yield();
| ^~~~~~~~~~~

The metal_yield API needs also to be declared for the baremetal systems.
This fix build issue in Open-amp for generic system:

/github/workspace/open-amp/lib/rpmsg/rpmsg_virtio.c:275:17:
error: implicit declaration of function 'metal_yield'
275 |                 metal_yield();
    |                 ^~~~~~~~~~~

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
@arnopo
Copy link
Contributor Author

arnopo commented Oct 21, 2024

@edmooring @tnmysh
I merge this one without your review to be able to fix CI and merge OpenAMP/open-amp#613 and freeze the code for the release

@arnopo arnopo merged commit 1ed90fd into OpenAMP:main Oct 21, 2024
6 checks passed
@arnopo arnopo deleted the fix_metal_yield branch October 22, 2024 07:56
@arnopo arnopo added this to the Release v2024.10 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant