Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include with EINVAL definition #544

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

zaporozhets
Copy link
Contributor

Hi,

The following PR fixes open-amp compilation with Vitis 2023.2 for cortex-R5F core. The compilation process stops with two errors in rpmsg_rpc_server.c and rpmsg_rpc_client.c due to undeclared EINVAL.

Let me know if you have any suggestions on this patch or better ideas on how to fix this issue(maybe in libmetal).

Please see the logs attached.

 /YOYO//workspace/ultra96_platform/psu_cortexr5_0/freertos_psu_cortexr5_0/bsp/include/xparameters.h:228: note: this is the location of the previous definition
       | 
 /YOYO//workspace/ultra96_platform/psu_cortexr5_0/freertos_psu_cortexr5_0/bsp/libsrc/openamp/src/lib/service/rpmsg/rpc/rpmsg_rpc_server.c: In function 'rpmsg_endpoint_server_cb':
[ERROR] /YOYO//workspace/ultra96_platform/psu_cortexr5_0/freertos_psu_cortexr5_0/bsp/libsrc/openamp/src/lib/service/rpmsg/rpc/rpmsg_rpc_server.c:61:25: error: 'EINVAL' undeclared (first use in this function)
       |                         ^~~~~~
 /YOYO//workspace/ultra96_platform/psu_cortexr5_0/freertos_psu_cortexr5_0/bsp/libsrc/openamp/src/lib/service/rpmsg/rpc/rpmsg_rpc_server.c:61:25: note: each undeclared identifier is reported only once for each function it appears in
 /YOYO//workspace/ultra96_platform/psu_cortexr5_0/freertos_psu_cortexr5_0/bsp/libsrc/openamp/src/lib/service/rpmsg/rpc/rpmsg_rpc_server.c: In function 'rpmsg_rpc_server_send':
[ERROR] /YOYO//workspace/ultra96_platform/psu_cortexr5_0/freertos_psu_cortexr5_0/bsp/libsrc/openamp/src/lib/service/rpmsg/rpc/rpmsg_rpc_server.c:88:25: error: 'EINVAL' undeclared (first use in this function)
     

@zaporozhets zaporozhets force-pushed the fix/add_missig_include branch 2 times, most recently from 9c8a733 to 648b59f Compare December 16, 2023 11:37
@tnmysh
Copy link
Collaborator

tnmysh commented Dec 18, 2023

@arnopo, @edmooring for reviews.

@arnopo arnopo self-requested a review December 19, 2023 08:28
Fixes open-amp compilation with Vitis 2023.2 due to undeclared EINVAL.

Signed-off-by: Taras Zaporozhets <zaporozhets.taras@gmail.com>
@arnopo arnopo merged commit 88ab928 into OpenAMP:main Dec 19, 2023
3 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants