remoteproc: Assign ops and priv to rproc struct in init by default #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to be set in the rproc specific init() callback currently, instead set them before calling the callback to make doing that in the callback optional. They can still be overwritten if needed in the init() callback but if this is not needed as in some simple cases, then the callback is not needed. Like other functions here, make this optional if no additional modifications to the rproc struct are needed. Signed-off-by: Andrew Davis <afd@ti.com>
This is handled by default, remove instances from apps. In cases where there is nothing left in the init() callback remove it as it is now optional. Signed-off-by: Andrew Davis <afd@ti.com>
arnopo
approved these changes
May 3, 2024
tnmysh
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.