Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio: Remove never used virtio_feature_name() #584

Merged
merged 1 commit into from
May 13, 2024

Conversation

glneo
Copy link
Contributor

@glneo glneo commented Apr 23, 2024

The comments states this was kept for "future use", that was a decade ago.. Remove this never used function and associated data.

Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glneo
Copy link
Contributor Author

glneo commented Apr 24, 2024

This depends on #583 going in first to remove the CI check fail.

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo
Copy link
Collaborator

arnopo commented May 3, 2024

@glneo : I merged #583. Please, could you rebase this one on top that the checks are all successful before I merge?

@arnopo
Copy link
Collaborator

arnopo commented May 3, 2024

@glneo : I merged #583. Please, could you rebase this one on top that the checks are all successful before I merge?

forget my request CI is broken. We need first to integrate #586

@glneo
Copy link
Contributor Author

glneo commented May 3, 2024

Okay, will re-push when that is fixed to kick off another CI build.

The comments states this was kept for "future use", that was a decade
ago.. Remove this never used function and associated data.

Signed-off-by: Andrew Davis <afd@ti.com>
@arnopo arnopo merged commit 2e5026f into OpenAMP:main May 13, 2024
3 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants