-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpmsg_virtio: Move get RX buffer into receive loop and returned buffer kick to common location #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have
no functional change but prepares for a later bug fix.
As commit message says this is needed for bug fix, then this change can be squashed in same commit where actual bug is fixed.
Okay, the bug fix I have in mind has a few more dependencies so for now I'll remove that part of the commit message. The patch should stand on its own just the same. |
After returning a buffer we kick the other side. This is done after both call sites of the function that returns the buffer. Move this kick call into that function to reduce code duplication and prevent it from not being done after returning the buffer. Signed-off-by: Andrew Davis <afd@ti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remark else LGTM
This allows us to only need to call rpmsg_virtio_get_rx_buffer() once at the start of the loop and is easier to comprehend. Signed-off-by: Andrew Davis <afd@ti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.