Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement alternative card design for issue #96 #113

Closed
wants to merge 1 commit into from
Closed

Conversation

DelaraGi
Copy link
Collaborator

@DelaraGi DelaraGi commented Oct 25, 2023

This pull request shows what the website front page could look like with the blog post cards being shown underneath the static OpenAMP text, rather than in a jumbotron.

@wmamills
Copy link

Thanks for the work.

However, this PR comment and commit header have no context or explanation. To me, this is un-reviewable in the current state. Even if I liked the result, the commit would need to be cleaned up to go in. How is this a "fix"? What is being fixed?
(Yes the preview is viewable but the commit needs context).

If this is the implementation of Philip's other Idea for the home page, I must say I prefer the jumbotron version. (Just my opinion Nathalie may disagree.)

If this commit is doing other unrelated cleanup that is needed please separate it and explain what is going on.

Thanks,
Bill

@pcolmer
Copy link
Collaborator

pcolmer commented Dec 12, 2023

@wmamills apologies for the poor subject and lack of description.

This pull request is, indeed, to show what the website would look like using cards instead of a jumbotron. I am concerned that putting the jumbotron in the header section does not lead to a very attractive design, particularly since you lose the message about the purpose of OpenAMP.

However, it is ultimately up to you & Nathalie. If you don't like this design, simply close the PR and we'll mark the original issue as done.

@pcolmer pcolmer changed the title fix: homepage Implement alternative card design for issue #96 Dec 12, 2023
@nathalie-ckc
Copy link
Collaborator

Hi,
I'm 50/50 on the 2 options as both have their pros & cons.
I see the benefit of having the blog posts appear in the jumbotron, as this is above the fold. So if we're trying to flash the latest & greatest, this helps. The tradeoff is what @pcolmer mentions - that the purpose gets hidden.
The cards at the bottom is cleaner, but might not be seen by someone who doesn't scroll.
Since I'm 50/50 and @wmamills 's preference is to keep the Jumbotron, let's go with that. I will close this PR & OK to mark the original issue as done. Thanks for providing the 2 options for comparison!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants