Fix : Local development failing due to changed function definition #776
Conversation
| @@ -24,7 +25,7 @@ def main() -> None: | |||
| subprocess.run(["git", "pull", "-q"]) | |||
| logger.info("Updated the OpenAdapt App") | |||
|
|
|||
| run_app() # start gui | |||
| start() # start gui | |||
There was a problem hiding this comment.
@shashank40 thank you for putting this together!
@KIRA009 do you know whether we are using this file openadapt/start.py anywhere? Git blame shows last update was about a year go
@shashank40 I think this file is deprecated. Can you please clarify what caused you to attempt to run it? If it's documented somewhere we should clarify that it is deprecated.
There was a problem hiding this comment.
We are not. This script looks like it updates the state of your local repo, but I don't think this is needed any more now that we have apps
There was a problem hiding this comment.
@shashank40 please feel free to move this file to openadapt/deprecated, and remove any mention of it in any documentation that you encountered 🙏
There was a problem hiding this comment.
@shashank40 Sorry for being confused, but when you say the app wasn't working in the first instance, did you mean the compiled version (the link you find on https://openadapt.ai/) or did you set it up manually from the git repo?
There was a problem hiding this comment.
@KIRA009
I meant the compiled app as i commented here.
#771 (comment)
| @@ -35,20 +35,20 @@ class VanillaReplayStrategy(strategies.base.BaseReplayStrategy): | |||
| def __init__( | |||
| self, | |||
| recording: models.Recording, | |||
| replay_instructions: str = "", | |||
| instructions: str = "", | |||
There was a problem hiding this comment.
@shashank40 if you remove the rest of this PR and only include the changes to this file I will be happy to merge it 👍
shashank40
force-pushed
the
fix/local_development_record_replay_failing
branch
from
77b1e26
to
8418f03
Compare
openadapt/strategies/vanilla.py
Outdated
| @@ -195,7 +195,7 @@ def generate_action_event( | |||
| current_window=current_window_dict, | |||
| recorded_actions=recorded_action_dicts, | |||
| replayed_actions=replayed_action_dicts, | |||
| replay_instructions=replay_instructions, | |||
| instructions=instructions, | |||
There was a problem hiding this comment.
I believe this needs to stay as "replay_instructions", as per the .j2 file
There was a problem hiding this comment.
But replay fails.
If we use the replay command with --instructions, it fails with the error, undefined argument instructions.
We can do 2 things
either the command we use has--replay_instructions as argument OR vanilla.py changes replay_instructions -> instructions.
I would change it to whatever you might prefer
There was a problem hiding this comment.
To clarify:
this line should read replay_instructions=instructions
This should not produce any error. If it does, please post the full log output.
There was a problem hiding this comment.
Oh yess, it would, missed the line number. You are correct
There was a problem hiding this comment.
@abrichr updated the PR 🙏🏻
shashank40
force-pushed
the
fix/local_development_record_replay_failing
branch
from
8cfe023
to
4f491fd
Compare
shashank40
force-pushed
the
fix/local_development_record_replay_failing
branch
from
a3fc674
to
014891a
Compare
shashank40
force-pushed
the
fix/local_development_record_replay_failing
branch
from
014891a
to
98e74cd
Compare
What kind of change does this PR introduce?
fixes #773
Summary
The current local development setup is buggy due to recent code changes. The helper function definitions were changed but the usage was not updates.
Ex: functions for recording start, replay etc
Checklist
How can your code be run and tested?
Other information