Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue #444 #874

Merged
merged 5 commits into from
Jun 18, 2023
Merged

Fix the issue #444 #874

merged 5 commits into from
Jun 18, 2023

Conversation

Ali7040
Copy link
Contributor

@Ali7040 Ali7040 commented Jun 15, 2023

Fix #444

@vercel
Copy link

vercel bot commented Jun 15, 2023

@Ali7040 is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jun 18, 2023 2:17pm

.yarnrc.yml Outdated
@@ -0,0 +1 @@
nodeLinker: node-modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this was added?

@vnugent
Copy link
Contributor

vnugent commented Jun 15, 2023

The unit test was failing due to some HTML Canvas test snapshot changes. I think it's ok to update the snapshot and push new commit.

yarn test -u

@vnugent vnugent temporarily deployed to Preview June 18, 2023 14:16 — with GitHub Actions Inactive
@vnugent
Copy link
Contributor

vnugent commented Jun 18, 2023

@Ali7040 I undid changes to yarn.lock and removed the extra / in the image path. Thank you for your help!


Screenshot 2023-06-18 at 7 31 43 AM

@vnugent vnugent merged commit e10595c into OpenBeta:develop Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photos on Popular page don't load
2 participants