fix: expose boltsCount and pitches in GraphQL mutation SingleClimbChangeInput
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f disciplines/type variable between Climb and Pitches expose boltsCount and pitches in GraphQL mutation, harmonise naming of disciplines variable
l4u532
force-pushed
the
fix/expose-hidden-db-fields
branch
from
8dacaeb
to
daa8513
Compare
l4u532
changed the title
boltsCount and pitches in GraphQL mutation SingleClimbChangeInputboltsCount and pitches in GraphQL mutation SingleClimbChangeInput
l4u532
commented
Jan 10, 2024
| input DisciplineType { | ||
| "https://en.wikipedia.org/wiki/Traditional_climbing" |
There was a problem hiding this comment.
Removed these comments to clean up code
vnugent
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mutation SingleClimbChangeInput is actually missing the fields
boltsCountandpitches. Hence, these cannot be safely updated using the GraphQL Mutation. This should finalise #350.What’s changed:
boltsCountandpitchesin MutationSingleClimbChangeInputPitch.gradestoPitch.gradeand harmonised behaviour ofClimb.gradewithPitch.gradeparentIdoptional, since individual pitches cannot be updated anyway without providing a parent climb’suuid(== a pitch’sparentId); also, this was preventing comfortably adding a climb + its pitches in one, single MutationpitchNumberis unique for a given Mutation