Ignore case of MAC addresses and fix postgres log messages #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid having MAC addresses of different case being stored separately, MAC addresses are stored in their lower-case form and any time MAC address comparison occurs (e.g. for deletion/update/retrieval), the passed MAC address is converted to lower case before the comparison is done, effectively ignoring case. This ensures that a difference in case does not result in duplicate MAC addresses.
synackd
force-pushed
the
case-insensitive-macs
branch
from
7bd6975
to
bb0901a
Compare
|
Rebased onto new |
synackd
pushed a commit
to synackd/bss
that referenced
this pull request
Feb 29, 2024
Add flag and environment variable for OAUTH2 server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Ignore case when dealing with MAC addresses. This is done by storing MAC addresses in lower case and converting any MAC addresses in requests to lower case before comparison. It is not desirable to distinguish MAC addresses as different based on case; therefore, we ignore it.
Also, some log message reformatting is present in this PR. For instance, there was a
postgres.Addprefix in theDelete()function. Further, periods at the ends of log messages are removed so that it looks better when concatenated with other errors.Issues and Related PRs
Migrated from bikeshack/hms-bss#7
Testing
Tested on:
cg-headand compute nodes)Added integration tests that test addition/retrieval/deletion using MAC addresses of differing case.
Risks and Mitigations
More comprehensive integration tests should be implemented in the future.