Patch 1 #263
Merged
Patch 1 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge suggestion by @pavel-kirienko Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
This change fixes the support for a built-in, default variable length array implementation for C++ types that can be overridden by the user. To accomplish this the concept of “support resource type” was added to allow different behavior for serialization support resource than for datatype support resources.
almost there.
thirtytwobits
commented
Aug 31, 2022
SchoberMJ
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Overall looks good, not a C++ guru so I'm not sure I can provide appropriate feedback to the internal_compare function of the VLA.
Python code gen sections look clean. I'm not familiar with the documentation format of the doc strings, in particular lines 134-154 of src/nunavut/lang/cpp/init.py just looks like left over code to me.
pavel-kirienko
approved these changes
Sep 25, 2022
|
There is one potentially serious issue discovered by Sonar though: https://sonarcloud.io/project/issues?pullRequest=263&issues=AYKyzbSpjX57U6EJSHck&open=AYKyzbSpjX57U6EJSHck&id=OpenCyphal_nunavut |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, completed work to support the built-in variable_length_array built-in.
I still owe this project: