[PATCH v5] validation: random: limit duration of some tests #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
MatiasElo
reviewed
Aug 28, 2024
JereLeppanen
force-pushed
the
dev/shorten-arm-rng-true-test
branch
from
b18a3df
to
0a68fcf
Compare
odpbuild
changed the title
test/validation/api/random/random.c
Outdated
| @@ -252,6 +254,9 @@ static void random_test_frequency(odp_random_kind_t kind) | |||
| bits, chisq, cells - 1, crit, res_str(chisq < crit)); | |||
|
|
|||
| CU_ASSERT(chisq < crit); | |||
|
|
|||
| if (odp_time_local_ns() - start > 5 * ODP_TIME_SEC_IN_NS) | |||
There was a problem hiding this comment.
Do we really need 5 secs here and in the other place? Wouldn't just 1 sec be enough? That is about the point where lowering the time out does not speed up the test much more due to the constant overhead of running the test (or else I would suggest less than 1 sec timeout).
There was a problem hiding this comment.
In some environments, with a one second limit, we break after executing the loop just once, and that's with bits=1, which is a kind of a special case. But I don't think that matters much. In the other place one second is probably fine.
There was a problem hiding this comment.
One could check if (bits > 1 && odp_time_local_ns() - start > ODP_TIME_SEC_IN_NS), but I'm fine with this version. The check can be optimized later if deemed necessary.
There was a problem hiding this comment.
Time limit is one second in v3, because there's not enough reasons for a longer limit.
MatiasElo
approved these changes
Aug 29, 2024
JereLeppanen
force-pushed
the
dev/shorten-arm-rng-true-test
branch
from
0a68fcf
to
db3c024
Compare
odpbuild
changed the title
|
v3:
|
JereLeppanen
changed the title
MatiasElo
reviewed
Sep 3, 2024
JereLeppanen
force-pushed
the
dev/shorten-arm-rng-true-test
branch
from
db3c024
to
5625374
Compare
odpbuild
changed the title
|
v4:
|
MatiasElo
approved these changes
Sep 3, 2024
Two of the randomness tests are too slow with ARM RNG true random. Limit the time that those tests are allowed to run. This saves about one minute in some environments. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Rename the -t,--threads option to -c,--num_cpu, to conform to the convention used by most of the other test programs. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
To reduce output clutter, remove an unnecessary odp_shm_print_all() call. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Add option -t,--time, which can be used to set a target test duration per random data type. The default is 500 msec, so the default test duration is half a second times the number of available random data types. This saves about half a minute in some environments. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
JereLeppanen
force-pushed
the
dev/shorten-arm-rng-true-test
branch
from
5625374
to
81d052a
Compare
odpbuild
changed the title
|
v5:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.