[PATCH v1] validation: pktio: separate and reduce packet and rx counts #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the magic number 1000 used for test packet counts and rx attempt counts with two macros. Lower the test packet count to 100 since the used pool configuration did not allow allocating more than 128 packets anyway. Make the rx attempt count twice the test packet count to leave room for a few possible non-test packets and to allow almost 100 ms for the first sent test packet to come back. The previous code had a higher rx attempt count than the test packet count but that was apparently accidental due to the pool config limiting the test packet count. The 1000 used for the rx attempt count was higher than necessary and slowed down the test slightly. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the magic number 1000 used for test packet counts and rx attempt counts with two macros. Lower the test packet count to 100 since the used pool configuration did not allow allocating more than 128 packets anyway. Make the rx attempt count twice the test packet count to leave room for a few possible non-test packets and to allow almost 100 ms for the first sent test packet to come back.
The previous code had a higher rx attempt count than the test packet count but that was apparently accidental due to the pool config limiting the test packet count. The 1000 used for the rx attempt count was higher than necessary and slowed down the test slightly.