Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be clear which functions are intended to be called externally and which aren't #11

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Be clear which functions are intended to be called externally and which aren't #11

merged 2 commits into from
Dec 11, 2024

Conversation

odscjames
Copy link
Contributor

@odscjames odscjames commented Dec 11, 2024 •
edited
Loading

get_fields_present_with_examples is not currently used externally and could technically be internal, but it looks very useful.

#10

@odscjames odscjames self-assigned this Dec 11, 2024
@odscjames odscjames changed the title 2024 12 11 Be clear which functions are intended to be called externally and which aren't Dec 11, 2024
@radix0000 radix0000 self-requested a review December 11, 2024 16:44
radix0000
radix0000 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@radix0000 radix0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@odscjames odscjames merged commit dc9432b into main Dec 11, 2024
12 checks passed
@odscjames odscjames deleted the 2024-12-11 branch December 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radix0000 radix0000 radix0000 approved these changes

Assignees

@odscjames odscjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odscjames @radix0000