Adds an opcode count stat to the disassembler

OpenDreamProject · Dec 12, 2024 · 1ed2925 · 1ed2925
1 parent 82693c1
commit 1ed2925
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 17 deletions.
diff --git a/DMDisassembler/DMProc.cs b/DMDisassembler/DMProc.cs
@@ -9,7 +9,7 @@
 namespace DMDisassembler;
 
 internal class DMProc(ProcDefinitionJson json) {
-    private class DecompiledOpcode(int position, string text) {
+    internal struct DecompiledOpcode(int position, string text) {
         public readonly int Position = position;
         public readonly string Text = text;
     }
@@ -21,19 +21,7 @@ private class DecompiledOpcode(int position, string text) {
     public Exception exception;
 
     public string Decompile() {
-        List<DecompiledOpcode> decompiled = new();
-        HashSet<int> labeledPositions = new();
-
-        try {
-            foreach (var (position, instruction) in new ProcDecoder(Program.CompiledJson.Strings, Bytecode).Disassemble()) {
-                decompiled.Add(new DecompiledOpcode(position, ProcDecoder.Format(instruction, type => Program.CompiledJson.Types[type].Path)));
-                if (ProcDecoder.GetJumpDestination(instruction) is int jumpPosition) {
-                    labeledPositions.Add(jumpPosition);
-                }
-            }
-        } catch (Exception ex) {
-            exception = ex;
-        }
+        List<DecompiledOpcode> decompiled = GetDecompiledOpcodes(out var labeledPositions);
 
         StringBuilder result = new StringBuilder();
         foreach (DecompiledOpcode decompiledOpcode in decompiled) {
@@ -59,6 +47,24 @@ public string Decompile() {
         return result.ToString();
     }
 
+    public List<DecompiledOpcode> GetDecompiledOpcodes(out HashSet<int> labeledPositions) {
+        List<DecompiledOpcode> decompiled = new();
+        labeledPositions = new();
+
+        try {
+            foreach (var (position, instruction) in new ProcDecoder(Program.CompiledJson.Strings, Bytecode).Disassemble()) {
+                decompiled.Add(new DecompiledOpcode(position, ProcDecoder.Format(instruction, type => Program.CompiledJson.Types[type].Path)));
+                if (ProcDecoder.GetJumpDestination(instruction) is int jumpPosition) {
+                    labeledPositions.Add(jumpPosition);
+                }
+            }
+        } catch (Exception ex) {
+            exception = ex;
+        }
+
+        return decompiled;
+    }
+
     [CanBeNull]
     public string[] GetArguments() {
         if (json.Arguments is null || json.Arguments.Count == 0) return null;

diff --git a/DMDisassembler/Program.cs b/DMDisassembler/Program.cs
@@ -4,6 +4,7 @@
 using System.Linq;
 using System.Text;
 using System.Text.Json;
+using DMCompiler.Bytecode;
 using DMCompiler.Json;
 using JetBrains.Annotations;
 
@@ -118,6 +119,7 @@ private static void PrintHelp([CanBeNull] string command) {
                 Console.WriteLine("Prints various statistics. Usage: stats [type]");
                 Console.WriteLine("Options for [type]:");
                 Console.WriteLine("procs-by-type         : Prints the number of proc declarations (not overrides) on each type in descending order");
+                Console.WriteLine("opcode-count          : Prints the number of occurrences for each opcode in descending order");
                 break;
             }
             default: {
@@ -153,6 +155,10 @@ private static void Stats([CanBeNull] string statType) {
                 ProcsByType();
                 return;
             }
+            case "opcode-count": {
+                OpcodeCount();
+                return;
+            }
             default: {
                 Console.WriteLine($"Unknown stat \"{statType}\"");
                 PrintHelp("stats");
@@ -174,15 +180,37 @@ void ProcsByType() {
 
             Console.WriteLine("Type: Proc Declarations");
             foreach (var pair in typeIdToProcCount.OrderByDescending(kvp => kvp.Value)) {
-
                 var type = TypesById[pair.Key];
                 if (pair.Key == 0) {
-                    Console.WriteLine($"<global>: {pair.Value}");
+                    Console.WriteLine($"<global>: {pair.Value:n0}");
                 } else {
-                    Console.WriteLine($"{type.Path}: {pair.Value}");
+                    Console.WriteLine($"{type.Path}: {pair.Value:n0}");
                 }
             }
         }
+
+        void OpcodeCount() {
+            Console.WriteLine("Counting all opcode occurrences. This may take a moment.");
+            Dictionary<string, int> opcodeToCount = new Dictionary<string, int>();
+
+            // We need to fill the dict first in case there's any opcodes with 0 occurrences in the bytecode
+            foreach (string opcodeName in Enum.GetNames(typeof(DreamProcOpcode))) {
+                opcodeToCount.Add(opcodeName, 0);
+            }
+
+            foreach (DMProc proc in Procs) {
+                var decompiledOpcodes = proc.GetDecompiledOpcodes(out _);
+                foreach (var opcode in decompiledOpcodes) {
+                    var name = opcode.Text.Split(' ')[0];
+                    opcodeToCount[name] += 1;
+                }
+            }
+
+            Console.WriteLine("Opcode: Count");
+            foreach (var pair in opcodeToCount.OrderByDescending(kvp => kvp.Value)) {
+                Console.WriteLine($"{pair.Key}: {pair.Value:n0}");
+            }
+        }
     }
 
     private static void Search(string[] args) {