Only register movables' appearances when in PVS range

OpenDreamRuntime/AtomManager.cs

@@ -503,7 +503,7 @@ public ImmutableAppearance MustGetAppearance(DreamObject atom) {
             DreamObjectTurf turf => turf.Appearance,
             DreamObjectMovable movable => movable.SpriteComponent.Appearance!,
             DreamObjectArea area => area.Appearance,
-            DreamObjectImage image => image.IsMutableAppearance ? AppearanceSystem!.AddAppearance(image.MutableAppearance!, registerApearance: false) : image.SpriteComponent!.Appearance!,
+            DreamObjectImage image => image.IsMutableAppearance ? AppearanceSystem!.AddAppearance(image.MutableAppearance!, registerAppearance: false) : image.SpriteComponent!.Appearance!,
             _ => throw new Exception($"Cannot get appearance of {atom}")
         };
     }
@@ -517,7 +517,7 @@ public bool TryGetAppearance(DreamObject atom, [NotNullWhen(true)] out Immutable
         else if (atom is DreamObjectMovable movable && movable.SpriteComponent.Appearance is not null)
             appearance = movable.SpriteComponent.Appearance;
         else if (atom is DreamObjectImage image)
-            appearance = image.IsMutableAppearance ? AppearanceSystem!.AddAppearance(image.MutableAppearance!, registerApearance: false) : image.SpriteComponent?.Appearance;
+            appearance = image.IsMutableAppearance ? AppearanceSystem!.AddAppearance(image.MutableAppearance!, registerAppearance: false) : image.SpriteComponent?.Appearance;
         else if (atom is DreamObjectArea area)
             appearance = area.Appearance;
         else

OpenDreamRuntime/Objects/Types/DreamList.cs

@@ -727,7 +727,7 @@ public override void RemoveValue(DreamValue value) {
             return;
 
         _atomManager.UpdateAppearance(_owner, appearance => {
-            GetOverlaysList(appearance).Remove(_appearanceSystem.AddAppearance(overlayAppearance, registerApearance:false));
+            GetOverlaysList(appearance).Remove(_appearanceSystem.AddAppearance(overlayAppearance, registerAppearance:false));
         });
     }
 

OpenDreamRuntime/Rendering/DMISpriteSystem.cs

@@ -14,12 +14,16 @@ public override void Initialize() {
     }
 
     private void GetComponentState(EntityUid uid, DMISpriteComponent component, ref ComponentGetState args) {
-        args.State = new SharedDMISpriteComponent.DMISpriteComponentState(component.Appearance?.MustGetID(), component.ScreenLocation);
+        uint? appearanceId = (component.Appearance != null)
+            ? _appearance?.AddAppearance(component.Appearance).MustGetID()
+            : null;
+
+        args.State = new SharedDMISpriteComponent.DMISpriteComponentState(appearanceId, component.ScreenLocation);
     }
 
     public void SetSpriteAppearance(Entity<DMISpriteComponent> ent, MutableAppearance appearance, bool dirty = true) {
         DMISpriteComponent component = ent.Comp;
-        component.Appearance = _appearance?.AddAppearance(appearance);
+        component.Appearance = new ImmutableAppearance(appearance, _appearance);
         if(dirty)
             Dirty(ent, component);
     }

OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

@@ -7,6 +7,7 @@
 using Robust.Shared.Player;
 using Robust.Shared.Network;
 using System.Diagnostics;
+using Robust.Shared.Console;
 
 namespace OpenDreamRuntime.Rendering;
 
@@ -61,11 +62,10 @@ private void OnPlayerStatusChanged(object? sender, SessionStatusEventArgs e) {
                     if(proxyWeakRef.TryGetTarget(out var immutable))
                         sendData.Add(immutable.MustGetID(), immutable);
                 }
-                Logger.GetSawmill("appearance").Debug($"Sending {sendData.Count} appearances to new player {e.Session.Name}");
 
+                Logger.GetSawmill("appearance").Debug($"Sending {sendData.Count} appearances to new player {e.Session.Name}");
                 e.Session.Channel.SendMessage(new MsgAllAppearances(sendData));
             }
-
         }
     }
 
@@ -77,17 +77,21 @@ private void RegisterAppearance(ImmutableAppearance immutableAppearance) {
         _networkManager.ServerSendToAll(new MsgNewAppearance(immutableAppearance));
     }
 
-    public ImmutableAppearance AddAppearance(MutableAppearance appearance, bool registerApearance = true) {
+    public ImmutableAppearance AddAppearance(MutableAppearance appearance, bool registerAppearance = true) {
         ImmutableAppearance immutableAppearance = new(appearance, this);
 
+        AddAppearance(immutableAppearance, registerAppearance);
+    }
+
+    public ImmutableAppearance AddAppearance(ImmutableAppearance appearance, bool registerAppearance = true) {
         lock (_lock) {
-            if(_appearanceLookup.TryGetValue(new(immutableAppearance), out var weakReference) && weakReference.TryGetTarget(out var originalImmutable)) {
+            if(_appearanceLookup.TryGetValue(new(appearance), out var weakReference) && weakReference.TryGetTarget(out var originalImmutable)) {
                 return originalImmutable;
-            } else if (registerApearance) {
-                RegisterAppearance(immutableAppearance);
-                return immutableAppearance;
+            } else if (registerAppearance) {
+                RegisterAppearance(appearance);
+                return appearance;
             } else {
-                return immutableAppearance;
+                return appearance;
             }
         }
     }