Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transforms not rendering #1771

Merged
merged 12 commits into from
May 18, 2024
Merged

Conversation

amylizzle
Copy link
Contributor

Fixes #1584

@boring-cyborg boring-cyborg bot added the Client Involves the OpenDream client label May 6, 2024
@github-actions github-actions bot added the size/S label May 6, 2024
@wixoaGit
Copy link
Member

Resting on Paradise places me a tile off, up or right depending on my direction
image
image

If possible, I'd prefer a fix in RT itself. Not sure how complicated the matrix passing-around is in Clyde though.

@amylizzle
Copy link
Contributor Author

That's odd, it works perfectly on goon. I'll poke at it. Also I think this is the proper fix, we need to translate to the 0 coordinate before rotation regardless of what we do.

Oh I bet something is doubling the width of the render target for paradise characters!

@amylizzle
Copy link
Contributor Author

That was exactly what it is. I'm now using the diff between the pos and render target size to calculate the origin, this seems much more reliable.

Tested on goon, paradise, and testgame

@wixoaGit
Copy link
Member

I think this is the proper fix, we need to translate to the 0 coordinate before rotation regardless of what we do.

Maybe so with our current approach with CreateRenderTargetFlipMatrix().

@github-actions github-actions bot added size/M and removed size/S labels May 15, 2024
}

var pixelPosition = (iconMetaData.Position + positionOffset) * EyeManager.PixelsPerMeter;
var frame = iconMetaData.Texture;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@wixoaGit wixoaGit merged commit 18ba23b into OpenDreamProject:master May 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Involves the OpenDream client size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/atom.transform doesn't render
2 participants