Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgb2num accepts null #1795

Merged
merged 1 commit into from
May 16, 2024
Merged

rgb2num accepts null #1795

merged 1 commit into from
May 16, 2024

Conversation

Kapu1178
Copy link
Contributor

Closes #1794

Im not sure this is technically the correct way to fix this, but it seems fine?

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label May 16, 2024
@wixoaGit
Copy link
Member

Im not sure this is technically the correct way to fix this, but it seems fine?

DefaultValue is generally used when the DM reference explicitly mentions it having a default value, but this works.

@wixoaGit wixoaGit merged commit dc6eea1 into OpenDreamProject:master May 16, 2024
5 of 7 checks passed
@Kapu1178 Kapu1178 deleted the fixrgb2num branch June 25, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
Runtime Involves the OpenDream server/runtime size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rgb2num() throws a bad color exception when given null
2 participants
@Kapu1178 @wixoaGit