Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint using resharper #1797

Merged
merged 9 commits into from
May 23, 2024
Merged

Conversation

harryob
Copy link
Contributor

@harryob harryob commented May 19, 2024

implements linting using rider's annotation tool, resharper. these lints aren't annotated using standard github pattern as there is a Ton of them, and resharper outputs them in SARIF. the best fitting tool for this seems to be the codeql security analysis tool, which is odd for a linter, but i think it still provides handy annotation

oh no! new bad code!! (only shows new inspections on the pr, not existing ones)
CleanShot 2024-05-22 at 23 21 59@2x

new commit addresses the issue, the issue is flagged as fixed and minimised
CleanShot 2024-05-22 at 23 27 08@2x

@github-actions github-actions bot added size/M and removed size/S labels May 19, 2024
@harryob harryob force-pushed the resharper-annotations branch from 55a9dce to 5966cde Compare May 19, 2024 06:01
@github-actions github-actions bot added size/S and removed size/M labels May 19, 2024
@boring-cyborg boring-cyborg bot added the Client Involves the OpenDream client label May 19, 2024
@github-actions github-actions bot added size/M and removed size/S labels May 19, 2024
@github-actions github-actions bot added size/S and removed size/M labels May 19, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@wixoaGit
Copy link
Member

wixoaGit commented May 22, 2024

This gives a ton of errors for our XAML UI (~6 pages). Is there something that can be done about that?
image

@harryob
Copy link
Contributor Author

harryob commented May 22, 2024

This gives a ton of errors for our XAML UI (~6 pages). Is there something that can be done about that? image

that's odd, i never got anything reporting as an error on my fork. i'll add an exclusion for reporting anything on .xaml pages, given it seems to be misreporting for them anyway

@wixoaGit
Copy link
Member

Turns out to also be giving lots of errors for things defined in RobustToolbox. This is probably due to the RT projects being excluded.
image

@github-actions github-actions bot added size/M and removed size/S labels May 22, 2024
@harryob
Copy link
Contributor Author

harryob commented May 22, 2024

Turns out to also be giving lots of errors for things defined in RobustToolbox. This is probably due to the RT projects being excluded. image

added a flag to skip the build to cut linting times, but this ended up also skipping the restore that happened - manually forcing it the restore performing the build seems to ensure the analysis works correctly

CleanShot 2024-05-23 at 00 04 56@2x

@github-actions github-actions bot added size/S and removed size/M labels May 22, 2024
@wixoaGit wixoaGit merged commit d81e7a7 into OpenDreamProject:master May 23, 2024
9 checks passed
@harryob harryob deleted the resharper-annotations branch August 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Involves the OpenDream client size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants