-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a system for printing stats to the disassembler #2067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike709
commented
Oct 27, 2024
wixoaGit
requested changes
Dec 11, 2024
Co-authored-by: wixoa <wixoag@gmail.com>
Co-authored-by: wixoa <wixoag@gmail.com>
Co-authored-by: wixoa <wixoag@gmail.com>
wixoaGit
approved these changes
Dec 11, 2024
Console.WriteLine("Type: Proc Declarations"); | ||
foreach (var pair in typeIdToProcCount.OrderByDescending(kvp => kvp.Value)) { | ||
|
||
var type = TypesById[pair.Key]; |
Check warning
Code scanning / InspectCode
Incorrect blank lines: Incorrect number of blank lines near braces Warning
Incorrect number of blank lines near braces, expected maximum 0 instead of 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
stats
command to the disassembler which can be extended to provide various info about the bytecode. For now I've added aprocs-by-type
argument which prints the number of proc declarations on each type in descending order.I've also spruced up the
help
command with the ability to take acommand
argument to learn more about a specific command.Here's an excerpt from TG: