Unit test some world vars against bad const folding, fix world.system_type
#2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wixoaGit
requested changes
Nov 16, 2024
ike709
commented
Nov 16, 2024
boring-cyborg
bot
added
Compiler
ike709
changed the title
world vars against bad const foldingworld vars against bad const folding, fix world.system_type
wixoaGit
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't work until #2095 is fixed but it will prevent that from reoccurring.
Also tests against repeating the issue when #2094 is resolved.
Also fixes
world.system_typenot being a string. Woops.