Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stringifying infinity #2112

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix stringifying infinity #2112

merged 1 commit into from
Dec 1, 2024

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Nov 28, 2024 •
edited
Loading

Some notes:

  • The original unit test did not work in BYOND like... at all. Infinity is a number and only becomes "inf" when you try to stringify it.
  • -1#IND == 0 also doesn't pass in BYOND
  • OS variation was fixed in BYOND at some point (can't be bothered to track down the build number). I confirmed I get the same result on both linux and windows.

Original test:
image

New test:
image

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Nov 28, 2024
@ike709 ike709 requested a review from wixoaGit November 28, 2024 18:40
@ike709 ike709 changed the title Fix a broken unit test Fix stringifying infinity Nov 28, 2024
@wixoaGit wixoaGit merged commit 610688c into OpenDreamProject:master Dec 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
Runtime Involves the OpenDream server/runtime size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ike709 @wixoaGit