Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't instantiate multidimensional lists in proc params #2125

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Don't instantiate multidimensional lists in proc params #2125

merged 1 commit into from
Dec 8, 2024

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Dec 7, 2024 •
edited
Loading

In BYOND /proc/foo(bar[5]) treats bar as null but OD was instantiating a multidimensional list (of 1 dimension).

Fixed 3 unit tests.

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Dec 7, 2024
@ike709
Copy link
Collaborator Author

ike709 commented Dec 7, 2024

CI failing due to NebulaSS13/Nebula#4619

@ike709 ike709 closed this Dec 7, 2024
@ike709 ike709 reopened this Dec 7, 2024
@wixoaGit wixoaGit merged commit 939512d into OpenDreamProject:master Dec 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
Compiler Involves the OpenDream compiler size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ike709 @wixoaGit