Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one in regex replace and add test #2144

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

amylizzle
Copy link
Contributor

This was subtly breaking DMM suite when there was a cell with more than one var-edited string var, which caused one tile to fail to load properly on goon and made the nuclear reactor control computer not work on devtest.

What a ride that was.

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Dec 17, 2024
@wixoaGit wixoaGit enabled auto-merge (squash) December 18, 2024 20:04
@wixoaGit wixoaGit merged commit 5483541 into OpenDreamProject:master Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime Involves the OpenDream server/runtime size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants