More consistent hillshading across zoom levels #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There's also a consistency problem with color scaling, due to contrast stretching in the hillshading intensity calculation. Working on a fix for that.. |
|
Current map view (left) vs export (right):
After disabling contrast stretching:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the dynamic tiler applies hillshading inconsistently, e.g. at higher zoom levels the shading appears "lighter" than lower zoom levels. This can be noticed when zooming in/out. This is because the formula for
delta_scalewas linear, instead of quadratic, which is incorrect.This would also lead to inconsistencies when exporting hillshaded DEMs, where the hillshading looked particularly "light" instead of looking like on-screen.