Implement Tibber Meter with SML Parsing and Enhance HttpBridge for Byte Requests #2597
Conversation
This implements the ShellyPlus1PM. https://www.shelly.com/de/products/shop/shelly-plus-1-pm
…plus1pm directory
Implement Shelly Plus1PM
…plus1pm directory
As discussed in the Community: https://community.openems.io/t/neues-meter-sdm-120/2385/7?u=sn0w3y
* Add files via upload * Delete src/io/openems/edge/io/opendtu directory * openDTU Implementation first commit * Update EdgeApp.bndrun * Delete bnd.bnd * Delete readme.adoc
|
|
|
Can you please update the code. Aftewards please set @michaelgrill as a first reviewer for the HTTP-Bridge part. We might have to split this into multiple PRs, because different reviewers will be involved. |
|
@sfeilmeier Unfortunately I can not set @michaelgrill as Reviewer:
GraphQL: Sn0w3y does not have the correct permissions to execute |
|
|
2 similar comments
|
|
|
|
Sn0w3y
changed the title
Sn0w3y
changed the title
|
@michaelgrill: Der Code muss noch aufgeräumt werden, aber kannst du dir bitte schon mal die HTTP-Bridge-Erweiterungen anschauen? |
|
|
|
|
1 similar comment
|
|
| } | ||
| } | ||
| // Read response | ||
| try (InputStream in = connection.getInputStream()) { |
There was a problem hiding this comment.
kann man die zwei methoden nicht zusammen führen, die sehen ja sehr ähnlich aus
| * @param endpoint the {@link Endpoint} to fetch | ||
| * @return the result response future containing the raw byte array | ||
| */ | ||
| CompletableFuture<byte[]> requestRaw(Endpoint endpoint); |
There was a problem hiding this comment.
wahrscheinlich wäre auch hier besser einen HttpResponse zu returnen
|
|
||
| @Override | ||
| public void handleEvent(Event event) { | ||
| this.generateGetRequest(); |
There was a problem hiding this comment.
für das wäre es besser wenn man wie die anderen methoden eine subscribeCycle methode hat in der BridgeHttp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2597 +/- ##
==============================================
- Coverage 50.70% 25.60% -25.09%
==============================================
Files 2100 224 -1876
Lines 96427 5508 -90919
Branches 6530 807 -5723
==============================================
- Hits 48880 1410 -47470
+ Misses 45851 4028 -41823
+ Partials 1696 70 -1626 |
Summary of Changes:
1. HttpBridge Enhancements:
HttpBridgecomponent to support requests for byte data from endpoints. This enhancement allows for more versatile handling of binary data and improves the bridge's capability to interact with a wider range of APIs and data formats.2. SML Parsing for Tibber Meter:
Justification:
These changes were introduced to address specific needs within our system architecture:
HttpBridgebroadens our capability to interact with various data sources, making our system more flexible and capable of handling binary data.