Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React hooks for line, bar, compare & map graphics pages #888

Closed
huss opened this issue Apr 19, 2023 · 2 comments
Closed

React hooks for line, bar, compare & map graphics pages #888

huss opened this issue Apr 19, 2023 · 2 comments
Milestone
2.0 release

Comments

@huss
Copy link
Member

huss commented Apr 19, 2023

Is your feature request related to a problem? Please describe.

Please see issue #726 for information.

Describe the solution you'd like

The graphic pages located in files src/client/app/containers/LineChartContainer.ts, src/client/app/containers/BarChartContainer.ts, src/client/app/containers/CompareChartContainer.ts & src/client/app/containers/MapChartContainer.ts need to be updated for React hooks. The look of the page will stay the same.

Note that each of the Containers interacts with react-plotly using the old style mapStateToProps. Information on a way to just use a Component is available. Some useful links may be react-plotly README and React Plotly information page. Many other help pages are available.

Additional context

src/client/app/components/DashboardComponent.tsx is part of another issue but changes may be needed.
@huss huss added the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Apr 19, 2023
@huss huss added this to the 1.1 release milestone Apr 19, 2023
@huss huss mentioned this issue May 9, 2023
Closed
10 tasks
@huss huss removed the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Sep 26, 2023
@ChrisMart21 ChrisMart21 mentioned this issue Jan 15, 2024
Merged
5 tasks
@ChrisMart21
Copy link
Contributor

#1113 Addresses All other than compare which still has a mapStateToProps container.

@huss huss mentioned this issue Apr 4, 2024
Open
@huss
Copy link
Member Author

huss commented Apr 4, 2024

Replaced with issue #1195 for last part.

@huss huss closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0 release
Development

No branches or pull requests
2 participants
@huss @ChrisMart21