Change while loop to for loop #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrwm Do you understand why those tests are failing? |
FlorianK13
approved these changes
Aug 16, 2023
|
@chrwm @jessymatar I finally figured out why those tests are failing: Github Secrets are not passed to Workflows from Pull Requests coming from forks (for security reasons). Hence these tests cannot use the API credentials and hence the tests fail. How should we proceed here @chrwm ? |
|
This is also implemented in #470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
With a for loop, we could run a specific number of iterations unlike while.
Also it is a test run to get to know the techniques with pull request.
Type of change (CHANGELOG.md)
Updated
Workflow checklist
PR-Assignee
Reviewer