Improve emulated EEPROM reload handling #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurKetels
requested changes
Apr 8, 2024
Add variable to control if ESC support read size 4 or 8 Byte. Depends on ESC. Add variable and function to set user function to perform emulated EEPROM reload. Add EEPROM error codes that can be used to indicatë crc error on reload. Include custom reload samples
nakarlsson
force-pushed
the
feature/improve_eeprom_reload_handling
branch
from
0c7becc to
4f0704d
Compare
|
When writing samples I got a idea of an alternative implementation. Second option is to pass eep_stat_t stat; as pointer to the custom reload. The custom reload will via that know the address. It can update the crc error directly... What do you think? |
|
Go for alternative 2 #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variable to control if ESC support read size 4 or 8 Byte. Depends on ESC.
Add variable and function to set user function
to perform emulated EEPROM reload.
Add EEPROM error codes that can be used to indicatë crc error on reload.
Fixes #178