Apply the FakeGroundEffect to all FWspan points #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebranlard
reviewed
Oct 4, 2023
ebranlard
approved these changes
Oct 4, 2023
|
considering backporting this to rc-3.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to be merged.
Feature or improvement description
Bug fix. The FakeGroundEffect is applied to all FW nodes. Current code did not apply the FakeGroundEffect to all FW points.
Related issue, if one exists
Possibly related to is issue #1787 since FW points can go below the ground.
Impacted areas of the software
aerodyn
Test results, if applicable
ad_VerticalAxis_OLAF with longer simulation time, free far-wake and turbine closer to the ground shows that FW points can go below the ground. This is fixed with the correction.