Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix with MSL2SWL #1804

Merged

Conversation

luwang00
Copy link
Contributor

This pull request fixes the issue identified and does not affect existing test results. However, it would be beneficial to check whether there are other bugs associated with MSL2SWL!=0.

Feature or improvement description
This is a bug fix to address the following issues:

  • HydroDyn not correctly processing members crossing the seabed when MSL2SWL!=0.
  • SeaState wave grid with default Z_Depth causing an error when MSL2SWL<0.
  • Water depth with the contribution from MSL2SWL included (measured from SWL instead of MSL) being passed to the other modules (HydroDyn, SubDyn, MAP++, and MoorDyn).

Impacted areas of the software
SeaState, HydroDyn, glue code with changes to the water depth input to SubDyn, MAP++, and MoorDyn.

Additional supporting information

  • SeaState overwrites WtrDpth with WtrDpth+MSL2SWL in SeaState InitOut, affecting other modules downstream using it as an input.
  • This pull request changes WtrDpth in SeaState InitOut back to the original water depth from the user input files without the contribution from MSL2SWL. A new variable called EffWtrDpth with the contribution from MSL2SWL is added to SeaState InitOut to avoid confusion.
  • Right now, WtrDpth of the various submodules of SeaState and HydroDyn is actually the effective water depth, i.e., WtrDpth+MSL2SWL. This gives the correct behavior, but it might be beneficial to change the variable name to EffWtrDpth for clarity, like in the new SeaSt_WaveField module.
  • HydroDyn was not consistent when checking for joints below the seabed when evaluating joint-based hydrodynamic loads. This is now fixed.
  • The default value of Z_Grid did not account for nonzero MSL2SWL, causing an error. This is now fixed.

Test results, if applicable
Does not affect existing test results. Only impacts the results when MSL2SWL!=0.

SeaState overwrites WtrDpth with WtrDpth+MSL2SWL, affecting other modules downstream.
@luwang00 luwang00 marked this pull request as ready for review October 23, 2023 20:50
@andrew-platt andrew-platt self-requested a review October 23, 2023 20:56
@andrew-platt andrew-platt self-assigned this Oct 23, 2023
@andrew-platt andrew-platt added Type: Bug Module: HydroDyn Module: SeaState SeaState module for wave data generation labels Oct 23, 2023
@andrew-platt andrew-platt added this to the v4.0.0 milestone Oct 23, 2023
@andrew-platt andrew-platt merged commit f36dab9 into OpenFAST:dev-unstable-pointers Oct 23, 2023
21 checks passed
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: HydroDyn Module: SeaState SeaState module for wave data generation Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants