Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue identified and does not affect existing test results. However, it would be beneficial to check whether there are other bugs associated with
MSL2SWL!=0
.Feature or improvement description
This is a bug fix to address the following issues:
MSL2SWL!=0
.Z_Depth
causing an error whenMSL2SWL<0
.MSL2SWL
included (measured from SWL instead of MSL) being passed to the other modules (HydroDyn, SubDyn, MAP++, and MoorDyn).Impacted areas of the software
SeaState, HydroDyn, glue code with changes to the water depth input to SubDyn, MAP++, and MoorDyn.
Additional supporting information
WtrDpth
withWtrDpth+MSL2SWL
in SeaStateInitOut
, affecting other modules downstream using it as an input.WtrDpth
in SeaStateInitOut
back to the original water depth from the user input files without the contribution fromMSL2SWL
. A new variable calledEffWtrDpth
with the contribution fromMSL2SWL
is added to SeaStateInitOut
to avoid confusion.WtrDpth
of the various submodules ofSeaState
andHydroDyn
is actually the effective water depth, i.e.,WtrDpth+MSL2SWL
. This gives the correct behavior, but it might be beneficial to change the variable name toEffWtrDpth
for clarity, like in the newSeaSt_WaveField
module.Z_Grid
did not account for nonzeroMSL2SWL
, causing an error. This is now fixed.Test results, if applicable
Does not affect existing test results. Only impacts the results when
MSL2SWL!=0
.