Bug Fix: UA driver aero-elastic simulation had wrong sign #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "x dot" portion of the state-space equation should not change the sign of the aero forces named "GF" in a planning document authored by E. Branlard (file named Section2D_v4.pdf)
ebranlard
approved these changes
Aug 2, 2024
ebranlard
reviewed
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
When using the new aero-elastic capabilities in the UA driver, we noticed some simple cases that diverged. Further inspection led us to find a sign error in the LinDyn implementation (see matrix
BB).Related issue, if one exists
This was discussed in an email chain between Envision Energy and @ebranlard.
Impacted areas of the software
UA driver, SimMod=3
Additional supporting information
Test results, if applicable
I added a new regression test for UA driver to expose this bug, but the existing cases for the UA driver aren't run in GitHub, so... until that is added, this won't change any regression tests.