Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compute doc, adding other operations docs (e.g. backups) #167

Merged
merged 12 commits into from
Aug 24, 2023
Merged

Added compute doc, adding other operations docs (e.g. backups) #167

merged 12 commits into from
Aug 24, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Aug 19, 2023

Closes #30.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (b831756) 82.45% compared to head (779037f) 82.45%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          21       21           
  Lines        2679     2679           
=======================================
  Hits         2209     2209           
  Misses        470      470

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl dotsdl requested a review from mikemhenry August 21, 2023 03:09
@dotsdl
Copy link
Member Author

dotsdl commented Aug 21, 2023

@mikemhenry these docs are directly relevant to you in the near term with your OpenFE beta deployment work. Do you have time to give a review?

hmacdope
hmacdope reviewed Aug 21, 2023
View reviewed changes
docs/operations.rst Outdated Show resolved Hide resolved
mikemhenry
mikemhenry reviewed Aug 23, 2023
View reviewed changes
docs/compute.rst Outdated Show resolved Hide resolved
mikemhenry
mikemhenry reviewed Aug 23, 2023
View reviewed changes
docs/compute.rst Outdated Show resolved Hide resolved
mikemhenry
mikemhenry reviewed Aug 23, 2023
View reviewed changes
docs/compute.rst Outdated Show resolved Hide resolved
mikemhenry
mikemhenry reviewed Aug 23, 2023
View reviewed changes
docs/operations.rst Outdated Show resolved Hide resolved
mikemhenry
mikemhenry reviewed Aug 23, 2023
View reviewed changes
docs/operations.rst Outdated Show resolved Hide resolved
mikemhenry
mikemhenry approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few bits of feedback, but nothing blocking!

dotsdl and others added 7 commits August 23, 2023 12:07
@dotsdl dotsdl merged commit 233bc3a into main Aug 24, 2023
@dotsdl dotsdl mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmacdope hmacdope hmacdope left review comments

@mikemhenry mikemhenry mikemhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs : deployment / operations docs
4 participants
@dotsdl @codecov-commenter @mikemhenry @hmacdope