Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #297 #324

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Closes #297 #324

merged 5 commits into from
Nov 11, 2024

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Nov 7, 2024 •
edited
Loading

Closes #297.

@dotsdl dotsdl linked an issue Nov 7, 2024 that may be closed by this pull request
Passing in malformed inputs as "ScopedKeys" gives raw 500 error #297
Closed
@dotsdl dotsdl requested a review from ianmkenney November 7, 2024 03:49
@dotsdl
Copy link
Member Author

dotsdl commented Nov 7, 2024

Ready for review @ianmkenney!

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (2cf0ab5) to head (c1b9fad).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
alchemiscale/interface/api.py 0.00% 4 Missing ⚠️
alchemiscale/models.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   80.18%   80.10%   -0.09%     
==========================================
  Files          27       27              
  Lines        3472     3478       +6     
==========================================
+ Hits         2784     2786       +2     
- Misses        688      692       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ianmkenney
ianmkenney approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ianmkenney ianmkenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dotsdl @ianmkenney
Update alchemiscale/interface/client.py
c1b9fad 
@ianmkenney suggestion

Co-authored-by: Ian Kenney <ianmichaelkenney@gmail.com>
@dotsdl dotsdl merged commit fe387b0 into main Nov 11, 2024
4 of 7 checks passed
@dotsdl dotsdl deleted the issue-297 branch November 11, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmkenney ianmkenney ianmkenney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing in malformed inputs as "ScopedKeys" gives raw 500 error
2 participants
@dotsdl @ianmkenney