Use python < 3.13 for building docs #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python v3.13 removed imghdr, which is used by the versions sphinx we use for building our docs. Since we don't officially support 3.13 yet, we can get the docs working by adding this constraint. A better option would be to use newer versions of Sphinx, but that can be done in a different commit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 27 27
Lines 3478 3478
=======================================
Hits 2786 2786
Misses 692 692 ☔ View full report in Codecov by Sentry. |
|
Awesome, thank you @ianmkenney! I agree with your proposed solution here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python v3.13 removed imghdr, which is used by the versions sphinx we use for building our docs. Since we don't officially support 3.13 yet, we can get the docs working by adding this constraint. A better option would be to use newer versions of Sphinx, but that can be done in a different commit.
See sphinx-doc/sphinx#10440