Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning imports and adding dependencies #10

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Cleaning imports and adding dependencies #10

merged 5 commits into from
Dec 7, 2023

Conversation

ijpulidos
Copy link
Contributor

Cleaning unused imports and adding explicitly used dependencies to the CI/test environment file.

Resolves #9

@ijpulidos ijpulidos requested a review from mikemhenry November 8, 2023 19:53
@ijpulidos
Copy link
Contributor Author

We need to fix #11 that should fix the tests with the current openfe 0.14.0 release, before merging this one.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@6c17003). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   92.06%           
=======================================
  Files           ?        7           
  Lines           ?      416           
  Branches        ?        0           
=======================================
  Hits            ?      383           
  Misses          ?       33           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a pymbar pin and gufe >=0.9.5 so we don't pull in something old by mistake

devtools/conda-envs/test_env.yaml Outdated Show resolved Hide resolved
ijpulidos and others added 2 commits December 7, 2023 16:52
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
@ijpulidos ijpulidos requested a review from mikemhenry December 7, 2023 21:54
@mikemhenry mikemhenry enabled auto-merge December 7, 2023 21:59
@mikemhenry mikemhenry merged commit e01057c into main Dec 7, 2023
4 checks passed
@mikemhenry mikemhenry deleted the clean-deps branch December 7, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up deps before conda-forge release
3 participants